| created | 2025-02-09T00:16:05Z |
|---|---|
| begin | 2025-02-04T00:00:00Z |
| end | 2025-02-05T00:00:00Z |
| path | src/sys |
| commits | 1 |
| date | 2025-02-04T09:15:04Z | |||
|---|---|---|---|---|
| author | stsp | |||
| files | src/sys/dev/pci/if_iwm.c | log | diff | annotate |
| src/sys/dev/pci/if_iwn.c | log | diff | annotate | |
| src/sys/dev/pci/if_iwx.c | log | diff | annotate | |
| message |
back out 'fix wrong ifmedia check in intel wifi drivers'; change was wrong The reverted commit's message was: IFM_AUTO is a media sub-type, not a media mode. Should fix issues where only a subset of channels were scanned. While IFM_AUTO is indeed in the IFM_SUBTYPE range of the ifmedia word, what these checks were really trying to find out is whether any bits in the IFM_MODE range are set. Those bits indicate whether userland has fixed the phy mode to 11a/11b/11g etc. And because IFM_AUTO is zero this check works as intended, even though comparing IFM_MODE range values to a value declared in the IFM_SUBTYPE range is questionable coding style. Found while diagnosing an issue where qwx(4) is not honoring a fixed mode (e.g. it uses 11g APs while fixed to 11a mode). Patch for that is upcoming. Any issues with intel wifi drivers not scanning the correct subset of channels will need to be fixed elsewhere. |
|||