OpenBSD cvs log

created 2024-01-14T15:47:29Z
begin 2024-01-11T00:00:00Z
end 2024-01-12T00:00:00Z
path src/sys
commits 7

date 2024-01-11T09:52:19Z
author stsp
files src/sys/dev/pci/if_qwx_pci.c log diff annotate
message handle MHI M1->M2 state transitions in qwx(4)

When the device signals transition to state M1, the MHI driver may
set the device into M2 state to save power. The MHI device will be
woken up again by the driver ringing the wake doorbell register
before doing PCI reads/writes, which qwx(4) already implements.

date 2024-01-11T13:49:49Z
author bluhm
files src/sys/netinet/tcp_debug.c log diff annotate
src/sys/netinet/tcp_input.c log diff annotate
src/sys/netinet/tcp_subr.c log diff annotate
src/sys/netinet/tcp_timer.c log diff annotate
src/sys/netinet/tcp_usrreq.c log diff annotate
src/sys/netinet/tcp_var.h log diff annotate
message Fix white spaces in TCP.

date 2024-01-11T14:15:11Z
author bluhm
files src/sys/kern/uipc_domain.c log diff annotate
src/sys/kern/uipc_socket.c log diff annotate
src/sys/kern/uipc_socket2.c log diff annotate
src/sys/net/pfkeyv2.c log diff annotate
message Use domain name for socket lock.

Syzkaller with witness complains about lock ordering of pf lock
with socket lock. Socket lock for inet is taken before pf lock.
Pf lock is taken before socket lock for route. This is a false
positive as route and inet socket locks are distinct. Witness does
not know this. Name the socket lock like the domain of the socket,
then rwlock name is used in witness lo_name subtype. Make domain
names more consistent for locking, they were not used anyway.
Regardless of witness problem, unique lock name for each socket
type make sense.

Reported-by: [email protected]
Reported-by: [email protected]
OK mvs@

date 2024-01-11T14:15:12Z
author bluhm
files src/sys/netinet/in_proto.c log diff annotate
src/sys/netinet6/in6_proto.c log diff annotate
src/sys/sys/domain.h log diff annotate
src/sys/sys/protosw.h log diff annotate
src/sys/sys/socketvar.h log diff annotate
message Use domain name for socket lock.

Syzkaller with witness complains about lock ordering of pf lock
with socket lock. Socket lock for inet is taken before pf lock.
Pf lock is taken before socket lock for route. This is a false
positive as route and inet socket locks are distinct. Witness does
not know this. Name the socket lock like the domain of the socket,
then rwlock name is used in witness lo_name subtype. Make domain
names more consistent for locking, they were not used anyway.
Regardless of witness problem, unique lock name for each socket
type make sense.

Reported-by: [email protected]
Reported-by: [email protected]
OK mvs@

date 2024-01-11T17:13:48Z
author jan
files src/sys/arch/amd64/amd64/vmm_machdep.c log diff annotate
src/sys/dev/vmm/vmm.h log diff annotate
message fix build with VMM_DEBUG option

ok dv@

date 2024-01-11T19:16:26Z
author miod
files src/sys/arch/alpha/alpha/trap.c log diff annotate
src/sys/arch/amd64/amd64/trap.c log diff annotate
src/sys/arch/arm64/arm64/syscall.c log diff annotate
src/sys/arch/m88k/m88k/trap.c log diff annotate
src/sys/arch/mips64/mips64/trap.c log diff annotate
message Since no system call takes more than 6 arguments, and no more than one
off_t argument, there is no need to process more than 6 arguments on
64-bit platforms and 8 on 32-bit platforms.

Make the syscall argument gathering code simpler by removing never-used code
to fetch more arguments from the stack, and local argument arrays when pointing
to the trap frame does the job.

ok guenther@ jsing@

date 2024-01-11T19:16:27Z
author miod
files src/sys/arch/powerpc/powerpc/trap.c log diff annotate
src/sys/arch/powerpc64/powerpc64/syscall.c log diff annotate
src/sys/arch/riscv64/riscv64/syscall.c log diff annotate
src/sys/arch/sparc64/sparc64/trap.c log diff annotate
message Since no system call takes more than 6 arguments, and no more than one
off_t argument, there is no need to process more than 6 arguments on
64-bit platforms and 8 on 32-bit platforms.

Make the syscall argument gathering code simpler by removing never-used code
to fetch more arguments from the stack, and local argument arrays when pointing
to the trap frame does the job.

ok guenther@ jsing@