OpenBSD cvs log

created 2023-05-27T04:12:31Z
begin 2023-05-06T00:00:00Z
end 2023-05-13T00:00:00Z
path src/sys
commits 42

date 2023-05-06T08:07:10Z
author kevlo
files src/sys/dev/usb/if_ure.c log diff annotate
src/sys/dev/usb/if_urereg.h log diff annotate
message Add support for RTL8153D.

The RTL8153D chipset shares many similarities with the already supported
RTL8156B chip but additionally requires a few semi-unique configurations.

Tested by weerd@
ok jmatthew@

date 2023-05-07T12:45:21Z
author kn
files src/sys/net/pf_osfp.c log diff annotate
message Remove net lock from DIOCOSFP{FLUSH,ADD,GET} aka. OS fingerprinting

pf_osfp.c contains all the locking for these three ioctls, everything is
protected by the pf lock; assert/document it and inline acess to the global
list to eliminate useless function variables.

OK bluhm sashan

date 2023-05-07T16:23:23Z
author bluhm
files src/sys/net/if.c log diff annotate
src/sys/net/if_bridge.c log diff annotate
src/sys/net/if_var.h log diff annotate
src/sys/net/pf.c log diff annotate
src/sys/net/pf_norm.c log diff annotate
src/sys/netinet/if_ether.c log diff annotate
src/sys/netinet/ip_output.c log diff annotate
message I preparation for TSO in software, cleanup the fragment code. Use
if_output_ml() to send mbuf lists to interfaces. This can be used
for TSO, fragments, ARP and ND6. Rename variable fml to ml. In
pf_route6() split the if else block. Put the safety check (hlen +
firstlen < tlen) into ip_fragment(). It makes the code correct in
case the packet is too short to be fragmented. This should not
happen, but other functions also have this logic.
No functional change. OK sashan@

date 2023-05-07T16:23:24Z
author bluhm
files src/sys/netinet6/ip6_output.c log diff annotate
src/sys/netinet6/nd6.c log diff annotate
src/sys/netinet6/nd6_nbr.c log diff annotate
message I preparation for TSO in software, cleanup the fragment code. Use
if_output_ml() to send mbuf lists to interfaces. This can be used
for TSO, fragments, ARP and ND6. Rename variable fml to ml. In
pf_route6() split the if else block. Put the safety check (hlen +
firstlen < tlen) into ip_fragment(). It makes the code correct in
case the packet is too short to be fragmented. This should not
happen, but other functions also have this logic.
No functional change. OK sashan@

date 2023-05-08T11:47:52Z
author bluhm
files src/sys/netinet6/nd6.c log diff annotate
message As the nd6 mutex protects the lifetime of struct llinfo_nd6 ln,
nd6_mtx must be held longer in nd6_rtrequest() case RTM_RESOLVE.
OK kn@

date 2023-05-08T13:14:21Z
author bluhm
files src/sys/netinet6/nd6.c log diff annotate
message To make ND6 mp-safe, the life time of struct llinfo_nd6 *ln =
rt->rt_llinfo has to be guaranteed. Replace the complicated logic
in nd6_rtrequest() case RTM_ADD with what we have in ARP. This
avoids accessing ln here.
Digging through histroy shows a lot of refactoring that makes
rt_expire handling in RTM_ADD obsolete. Just initialize it to 0.
Cloning and local routes should never expire. If RTF_LLINFO is
set, ln should not be NULL. So nd6_llinfo_settimer() was not reached
in this case.
While there, remove obsolete comments and #if 0 code that never
worked.
OK kn@ claudio@

date 2023-05-08T13:22:13Z
author bluhm
files src/sys/net/pf.c log diff annotate
src/sys/netinet/ip_output.c log diff annotate
src/sys/netinet6/ip6_output.c log diff annotate
message The call to in_proto_cksum_out() is only needed before the packet
is passed to ifp->if_output(). The fragment code has its own
checksum calculation and the other paths end in goto bad.
OK claudio@

date 2023-05-08T23:52:36Z
author dlg
files src/sys/net/pfvar_priv.h log diff annotate
message fix up some formatting in the pf_state_list comment.

date 2023-05-09T10:13:23Z
author kettenis
files src/sys/arch/arm64/dev/aplcpu.c log diff annotate
message Apparently there is no need to set the PS2 field.

ok patrick@

date 2023-05-09T10:35:20Z
author kn
files src/sys/uvm/uvm_mmap.c log diff annotate
message Inline once-used variable to sync all uvm_map_clean() callers

OK mpi

date 2023-05-09T14:22:17Z
author visa
files src/sys/kern/sys_generic.c log diff annotate
src/sys/kern/sys_pipe.c log diff annotate
message Don't return EPIPE from pipe kqfilter

Proceed with the registration of an EVFILT_WRITE filter even if the
pipe's other end has been closed, instead of failing with error EPIPE.
The filter will trigger immediately. This reduces the possible outcomes
when a kevent(2) call and a close(2) call race on the different ends
of a pipe.

This fixes a failure of lang/ghc unit test as reported by gnezdo@.

OK gnezdo@ mpi@

date 2023-05-10T12:07:16Z
author bluhm
files src/sys/net/pf.c log diff annotate
src/sys/netinet/in.h log diff annotate
src/sys/netinet/ip_output.c log diff annotate
src/sys/netinet/tcp_output.c log diff annotate
src/sys/netinet/tcp_subr.c log diff annotate
src/sys/netinet/tcp_usrreq.c log diff annotate
src/sys/netinet/tcp_var.h log diff annotate
message Implement TCP send offloading, for now in software only. This is
meant as a fallback if network hardware does not support TSO. Driver
support is still work in progress. TCP output generates large
packets. In IP output the packet is chopped to TCP maximum segment
size. This reduces the CPU cycles used by pf. The regular output
could be assisted by hardware later, but pf route-to and IPsec needs
the software fallback in general.
For performance comparison or to workaround possible bugs, sysctl
net.inet.tcp.tso=0 disables the feature. netstat -s -p tcp shows
TSO counter with chopped and generated packets.
based on work from jan@
tested by jmc@ jan@ Hrvoje Popovski
OK jan@ claudio@

date 2023-05-10T12:07:17Z
author bluhm
files src/sys/netinet6/ip6_output.c log diff annotate
src/sys/sys/mbuf.h log diff annotate
message Implement TCP send offloading, for now in software only. This is
meant as a fallback if network hardware does not support TSO. Driver
support is still work in progress. TCP output generates large
packets. In IP output the packet is chopped to TCP maximum segment
size. This reduces the CPU cycles used by pf. The regular output
could be assisted by hardware later, but pf route-to and IPsec needs
the software fallback in general.
For performance comparison or to workaround possible bugs, sysctl
net.inet.tcp.tso=0 disables the feature. netstat -s -p tcp shows
TSO counter with chopped and generated packets.
based on work from jan@
tested by jmc@ jan@ Hrvoje Popovski
OK jan@ claudio@

date 2023-05-10T15:28:26Z
author krw
files src/sys/dev/usb/umass_scsi.c log diff annotate
src/sys/scsi/scsiconf.h log diff annotate
src/sys/scsi/sd.c log diff annotate
message Add flag SDEV_UFI so umass_scsi_attach() can provide information
sufficient to get sdgetdisklabel() to correctly set d_type to
DTYPE_FLOPPY in the default disklabel.

installboot(8) in particular likes to know it is dealing with a
floppy.

ok miod@

date 2023-05-10T18:26:05Z
author miod
files src/sys/dev/usb/usbdevs log diff annotate
message New udl(4) device, reported by "S V" on tech@

date 2023-05-10T18:26:43Z
author miod
files src/sys/dev/usb/usbdevs.h log diff annotate
src/sys/dev/usb/usbdevs_data.h log diff annotate
message regen

date 2023-05-10T18:28:04Z
author miod
files src/sys/dev/usb/udl.c log diff annotate
message New udl(4) device, reported by "S V" on tech@

date 2023-05-10T22:42:51Z
author sashan
files src/sys/net/pf_lb.c log diff annotate
src/sys/net/pfvar_priv.h log diff annotate
message nat-to may fail to insert state due to conflict on chosen source
port number. This is typically indicated by 'wire key attach failed on...'
message when pf(4) debugging is enabled. The problem is caused by
glitch in pf_get_sport() which fails to discover conflict in advance.
In order to fix it we must also calculate toeplitz hash in
pf_get_sport() to initialize look up key properly.

the bug has been kindly reported by joosepm _von_ gmail _dot_ com

OK dlg@

date 2023-05-11T09:51:33Z
author bluhm
files src/sys/kern/kern_ktrace.c log diff annotate
message mi_syscall() can add the KTRC_CODE_SYSCALL flag to the syscall code.
In ktrsyscall() mask the code, otherwise kdump(1) does not show the
correct mib of SYS_sysctl when called by syscall(2).
OK guenther@

date 2023-05-11T12:36:22Z
author kn
files src/sys/net/pf_ioctl.c log diff annotate
message pools are always initialised, zap overcautious NULL check

All pools are init'd after pfattach(), none is ever destroyed,
so struct pf_pool_limit's .pp always points to valid pools.

Drop a check for the impossible from twenty years ago.

OK sashan dlg

date 2023-05-11T16:55:46Z
author stsp
files src/sys/dev/pci/if_iwx.c log diff annotate
message Stop sending a PHY context update in iwx_run_stop()

Fixes firmware error iwx0: 0x20101A28 | ADVANCED_SYSASSERT which would
occur while tearing down the state of our association to the AP.

The problem occurred when we were trying to reconfigure the PHY context
in a way that is incompatible with the TLC configuration. Since we will
always call iwx_deauth() next, which removes the AP station and related
data such as TLC from firmware before updating the PHY context yet again
we can simply skip the redundant PHY context update in iwx_run_stop() to
prevent this firmware error.

A reliable way to reproduce the problem is an attempt to connect to an
11ac access point on a 5GHz channel while the wrong WPA key is set which
happened to me because mpi@ uses a French WPA passphrase.
Problem confirmed fixed by me with this simple reproducer.

Helpful hints provided by Johannes Berg at Linux/Intel, thanks!

date 2023-05-12T10:50:22Z
author jsg
files src/sys/dev/pci/drm/include/linux/apple-gmux.h log diff annotate
message add apple-gmux.h for 6.1.28 drm

date 2023-05-12T10:53:36Z
author jsg
files src/sys/dev/pci/drm/amd/display/dc/dcn30/dcn30_resource.c log diff annotate
src/sys/dev/pci/drm/amd/display/dc/dcn30/dcn30_resource.h log diff annotate
src/sys/dev/pci/drm/amd/display/dc/dcn31/dcn31_resource.c log diff annotate
src/sys/dev/pci/drm/amd/display/dc/dcn314/dcn314_resource.c log diff annotate
src/sys/dev/pci/drm/amd/display/dc/dcn314/dcn314_resource.h log diff annotate
src/sys/dev/pci/drm/amd/display/dc/dml/dcn30/dcn30_fpu.c log diff annotate
message drm/amd/display: Remove stutter only configurations

From Nasir Osman
5e1574aa0639abf811375aaba1d6799d035dc97b in linux-6.1.y/6.1.28
71c4ca2d3b079d0ba4d9b3033641fea906cebfb6 in mainline linux

date 2023-05-12T10:55:23Z
author jsg
files src/sys/dev/pci/drm/amd/display/dc/dcn314/dcn314_resource.c log diff annotate
message drm/amd/display: limit timing for single dimm memory

From Daniel Miess
2abff94db2c6d692772fc07f39b4f9ee894c7197 in linux-6.1.y/6.1.28
1e994cc0956b8dabd1b1fef315bbd722733b8aa8 in mainline linux

date 2023-05-12T10:57:58Z
author jsg
files src/sys/dev/pci/drm/amd/display/amdgpu_dm/amdgpu_dm_psr.c log diff annotate
src/sys/dev/pci/drm/amd/display/modules/power/power_helpers.c log diff annotate
src/sys/dev/pci/drm/amd/display/modules/power/power_helpers.h log diff annotate
message drm/amd/display: fix PSR-SU/DSC interoperability support

From Hamza Mahfooz
09c41688b6e5c038df5baacdb0f4e23c8a10ebdb in linux-6.1.y/6.1.28
13b90cf900ab69dd5cab3cc5035bc7614037e64e in mainline linux

date 2023-05-12T11:00:22Z
author jsg
files src/sys/dev/pci/drm/amd/display/modules/power/power_helpers.c log diff annotate
message drm/amd/display: fix a divided-by-zero error

From Alex Hung
e43cf7abece2efaebe0a757909d258212d01c404 in linux-6.1.y/6.1.28
0b5dfe12755f87ec014bb4cc1930485026167430 in mainline linux

date 2023-05-12T11:01:48Z
author jsg
files src/sys/dev/pci/drm/amd/pm/swsmu/amdgpu_smu.c log diff annotate
message swsmu/amdgpu_smu: Fix the wrong if-condition

From Yu Songping
d78777c1d4de809d8bc9efc697cb636cbe8e32c2 in linux-6.1.y/6.1.28
484d7dcc709da46a5976c9530eeff931e9ecba82 in mainline linux

date 2023-05-12T11:03:19Z
author jsg
files src/sys/dev/pci/drm/amd/pm/swsmu/amdgpu_smu.c log diff annotate
message drm/amd/pm: re-enable the gfx imu when smu resume

From Tim Huang
f455c9cb9eed246e398977d0d14ac57cd34cefeb in linux-6.1.y/6.1.28
f7f28f268b861c29dd18086bb636abedf0ff59ff in mainline linux

date 2023-05-12T11:06:39Z
author jsg
files src/sys/dev/pci/drm/include/drm/i915_pciids.h log diff annotate
message drm/i915/dg2: Drop one PCI ID

From Matt Roper
46473f3bd14a8d6887d2ee56c78aff682bf5d596 in linux-6.1.y/6.1.28
3a38be31ec82920a871963c086393bc0ba26a655 in mainline linux

date 2023-05-12T11:09:03Z
author jsg
files src/sys/dev/pci/drm/drm_probe_helper.c log diff annotate
message drm/probe-helper: Cancel previous job before starting new one

From Dom Cobley
809a3fb8d8fce5801300ead8aaf52a4ee102e0db in linux-6.1.y/6.1.28
a8e47884f1906cd7440fafa056adc8817568e73e in mainline linux

date 2023-05-12T11:14:00Z
author jsg
files src/sys/dev/pci/drm/amd/amdgpu/amdgpu_device.c log diff annotate
message drm/amdgpu: register a vga_switcheroo client for MacBooks with apple-gmux

From Orlando Chamberlain
78e32896ecc790994034a35a2edef0b6ae043537 in linux-6.1.y/6.1.28
d37a3929ca0363ed1dce02b2772cd5bc547ca66d in mainline linux

date 2023-05-12T11:16:58Z
author jsg
files src/sys/dev/pci/drm/ttm/ttm_pool.c log diff annotate
message drm/ttm: optimize pool allocations a bit v2

From Christian Koenig
5e5a4185c66f9478a8cb2f74eed1a5b5a5000b13 in linux-6.1.y/6.1.28
735c466465eba51deaee3012d8403c10fc7c8c03 in mainline linux

date 2023-05-12T11:19:12Z
author jsg
files src/sys/dev/pci/drm/ttm/ttm_pool.c log diff annotate
message drm/ttm/pool: Fix ttm_pool_alloc error path

From Thomas Hellstrom
d2151c5d9dbe3f8fec4cae5f4784edce3ced3a7e in linux-6.1.y/6.1.28
379989e7cbdc7aa7496a00ee286ec146c7599cf0 in mainline linux

date 2023-05-12T11:21:13Z
author jsg
files src/sys/dev/pci/drm/amd/display/amdgpu_dm/amdgpu_dm.c log diff annotate
message drm/amd/display: Fix potential null dereference

From Igor Artemiev
b75aaebac265e3f29863699d9a929fdfba13d0a4 in linux-6.1.y/6.1.28
52f1783ff4146344342422c1cd94fcb4ce39b6fe in mainline linux

date 2023-05-12T11:22:54Z
author jsg
files src/sys/dev/pci/drm/i915/display/intel_display.c log diff annotate
message drm/i915: Make intel_get_crtc_new_encoder() less oopsy

From Ville Syrjala
0fe6ef82e4f4764e8f556632e4cd93d78d448e99 in linux-6.1.y/6.1.28
631420b06597a33c72b6dcef78d1c2dea17f452d in mainline linux

date 2023-05-12T11:28:36Z
author jsg
files src/sys/dev/pci/drm/amd/display/dc/clk_mgr/dcn21/rn_clk_mgr_vbios_smu.h log diff annotate
message drm/amd/display (gcc13): fix enum mismatch

From Jiri Slaby
010842e88269b00b58c6deced7049ff818d73834 in linux-6.1.y/6.1.28
545094d993f4639482018becda5f2a47d126f0ab in mainline linux

date 2023-05-12T11:42:22Z
author jsg
files src/sys/dev/pci/pcidevs log diff annotate
message match 6.1.28 drm and remove Intel 0x5698

previously DG2-G11, Intel have now decided it is reserved for future use

date 2023-05-12T11:43:03Z
author jsg
files src/sys/dev/pci/pcidevs.h log diff annotate
src/sys/dev/pci/pcidevs_data.h log diff annotate
message regen

date 2023-05-12T12:40:49Z
author bluhm
files src/sys/netinet/if_ether.c log diff annotate
message Access rt_llinfo without checking RTF_LLINFO flag before. They are
always set together with ARP mutex.
OK mvs@

date 2023-05-12T12:42:16Z
author bluhm
files src/sys/netinet6/nd6.c log diff annotate
message Make access to rt_llinfo consistent and remove needless initialisation.
OK mvs@

date 2023-05-12T16:43:00Z
author kettenis
files src/sys/arch/arm64/stand/efiboot/conf.c log diff annotate
src/sys/arch/arm64/stand/efiboot/efiboot.c log diff annotate
message Fall back on loading the kernel from the EFI system partition if we're
booting from a disk without a BSD disklabel.

ok kn@, caspar@

date 2023-05-12T21:32:49Z
author uaa
files src/sys/arch/arm64/conf/RAMDISK log diff annotate
message add axppmic support to RAMDISK,
to support ethernet on OrangePi One Plus (Allwinner H6).

ok kettenis@