OpenBSD cvs log

created 2023-03-08T18:35:39Z
begin 2023-03-06T00:00:00Z
end 2023-03-07T00:00:00Z
path src/sys
commits 25

date 2023-03-06T02:34:53Z
author jsg
files src/sys/dev/pci/drm/amd/display/dc/dcn314/dcn314_hwseq.c log diff annotate
src/sys/dev/pci/drm/amd/display/dc/dcn314/dcn314_hwseq.h log diff annotate
src/sys/dev/pci/drm/amd/display/dc/dcn314/dcn314_init.c log diff annotate
src/sys/dev/pci/drm/amd/display/dmub/inc/dmub_cmd.h log diff annotate
message drm/amd/display: Move DCN314 DOMAIN power control to DMCUB

From Nicholas Kazlauskas
4da108082a3290804ebbd42d70ce8535c00e4637 in linux-6.1.y/6.1.15
e383b12709e32d6494c948422070c2464b637e44 in mainline linux

date 2023-03-06T02:38:01Z
author jsg
files src/sys/dev/pci/drm/amd/display/amdgpu_dm/amdgpu_dm.c log diff annotate
src/sys/dev/pci/drm/amd/display/amdgpu_dm/amdgpu_dm.h log diff annotate
src/sys/dev/pci/drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c log diff annotate
message drm/amd/display: Fix race condition in DPIA AUX transfer

From Stylon Wang
075e2099c32cf4486b27266d2aecf61e95499ea4 in linux-6.1.y/6.1.15
ead08b95fa50f40618c72b93a849c4ae30c9cd50 in mainline linux

date 2023-03-06T02:40:58Z
author jsg
files src/sys/dev/pci/drm/amd/display/amdgpu_dm/amdgpu_dm.c log diff annotate
message drm/amd/display: Properly reuse completion structure

From Stylon Wang
118ad80d27d938868299ef184f7483b21f011f0b in linux-6.1.y/6.1.15
0cf8307adbc6beb5ff3b8a76afedc6e4e0b536a9 in mainline linux

date 2023-03-06T10:16:16Z
author stsp
files src/sys/dev/pci/if_iwx.c log diff annotate
src/sys/dev/pci/if_iwxreg.h log diff annotate
message recognize more iwx ucode TLV sections which are present in newer fw images

date 2023-03-06T10:16:17Z
author stsp
files src/sys/dev/pci/if_iwxvar.h log diff annotate
message recognize more iwx ucode TLV sections which are present in newer fw images

date 2023-03-06T10:24:15Z
author stsp
files src/sys/dev/pci/if_iwx.c log diff annotate
src/sys/dev/pci/if_iwxreg.h log diff annotate
message add support for iwx firmware alive response version 6

date 2023-03-06T10:28:04Z
author stsp
files src/sys/dev/pci/if_iwx.c log diff annotate
src/sys/dev/pci/if_iwxreg.h log diff annotate
message add support for iwx TLC config command v4

date 2023-03-06T10:31:58Z
author stsp
files src/sys/dev/pci/if_iwx.c log diff annotate
src/sys/dev/pci/if_iwxreg.h log diff annotate
message change current iwx rate_n_flag field names to indicate this is API version 1

also add some missing bits found in the Linux driver while here

date 2023-03-06T10:48:05Z
author stsp
files src/sys/dev/pci/if_iwx.c log diff annotate
src/sys/dev/pci/if_iwxreg.h log diff annotate
src/sys/dev/pci/if_iwxvar.h log diff annotate
message support iwx rate_n_flags API version 2 and delete fixed Tx rate support

As of this commit iwx will ignore 'ifconfig media' commands where the
user-specified Tx rate resolves to something other than 'autoselect'.
The existing support for forcing a Tx rate was already only partially
working in 11n and 11ac modes. I doubt anyone had a serious use case for
this. If you really need to force a specific Tx rate for data frames
sent by iwx then hack the driver instead of using 'ifconfig media'.

The firmware interface was designed for Tx rate selection in firmware.
Maintaining support for overriding the Tx rate with ifconfig in face of
complicated firmware interface changes such as this rate_n_flags change
is just not worth it. While trying to keep forced Tx rates working on top
of the new rate_n_flags format I accidentally broke the Tx rate used for
managment frames during regular operation, which caused much frustration.

date 2023-03-06T10:52:16Z
author stsp
files src/sys/dev/pci/if_iwx.c log diff annotate
src/sys/dev/pci/if_iwxreg.h log diff annotate
message add support for the iwx RLC config command

New firmware wants to be told about MIMO antenna configuration via
a separate command, rather than via the good old PHY context command.

date 2023-03-06T11:00:41Z
author stsp
files src/sys/dev/pci/if_iwx.c log diff annotate
src/sys/dev/pci/if_iwxreg.h log diff annotate
message support the new IWX_STA_MAC_DATA_API_S_VER_2 API

MAC context command fields which firmware has been ignoring since the iwm
hardware generation have been repurposed for information related to 11ax.
Just set these fields to zero. Firmware -71 and up will panic otherwise.

date 2023-03-06T11:03:29Z
author stsp
files src/sys/dev/pci/if_iwx.c log diff annotate
src/sys/dev/pci/if_iwxreg.h log diff annotate
message implement support for iwx PHY context cmd version 4

date 2023-03-06T11:08:56Z
author stsp
files src/sys/dev/pci/if_iwx.c log diff annotate
src/sys/dev/pci/if_iwxreg.h log diff annotate
src/sys/dev/pci/if_iwxvar.h log diff annotate
message add support for the iwx BAID allocation config command

This command is required to set up Rx aggregation on new firmware.

date 2023-03-06T11:18:37Z
author stsp
files src/sys/dev/pci/if_iwx.c log diff annotate
src/sys/dev/pci/if_iwxreg.h log diff annotate
message support the new iwx SCD_QUEUE_CONFIG command

Required for adding/removing Tx queues on new firmware versions.

Semantics have changed yet again. Good old iwm(4) required manual
removal of related Tx queues when a station is removed from firmware.
At some point iwx(4) firmware removed this requirement and demanded
that queue removal would be done implicitly by firmware instead.
And now the firmware engineers at Intel have again changed their
minds about this, and explicit queue removal is required again.
It is sad that we are being driven through such a marathon of changes
just in order to pick up some firmware security fixes...

date 2023-03-06T11:21:24Z
author stsp
files src/sys/dev/pci/if_iwx.c log diff annotate
message fix iwx session protection event duration

Firmware expects time in TU units.
Use 900 TU for the session protection timeout, like the linux driver does.

verified with Johannes Berg from Linux/Intel, thanks for the support!

date 2023-03-06T11:28:01Z
author stsp
files src/sys/dev/pci/if_iwx.c log diff annotate
message always provide a subset of STA info in the MAC context command

We used to provide beacon-related information only once our station was
associated. New firmware wants to see this information earlier, when are
about to send an AUTH frame. Otherwise SYSASSERT 0x2000011A is raised.

Problem diagnosed with help from Johannes Berg, thanks!

date 2023-03-06T11:30:46Z
author stsp
files src/sys/dev/pci/if_iwx.c log diff annotate
message ignore iwx DATA_PATH group notification 0xf8

Undocumented and ignored by the Linux driver, too.
Apparently only used by the Windows driver.
Confirmed by Johannes Berg.

date 2023-03-06T11:33:57Z
author stsp
files src/sys/dev/pci/if_iwx.c log diff annotate
message Avoid trying to remove keys if the station is not active in iwx firmware.

Fixes a firmware panic I encountered while working on firmware upgrades.

date 2023-03-06T11:37:14Z
author stsp
files src/sys/dev/pci/if_iwx.c log diff annotate
message fix previous: only ignore request to delete key while doing crypto in hardware

date 2023-03-06T11:42:11Z
author stsp
files src/sys/dev/pci/if_iwx.c log diff annotate
message Make iwx(4) get the primary channel number from AP beacon info, rather
than assuming that it always matches our currently configured channel.
Should prevent problems on 40/80Mhz channels if there is a mismatch.

date 2023-03-06T11:53:24Z
author stsp
files src/sys/dev/pci/if_iwxvar.h log diff annotate
message Switch all iwx(4) devices to -77 firmware images.

New firmware versions address some security issues, as outlined here:
https://www.intel.com/content/www/us/en/security-center/advisory/intel-sa-00621.html
https://www.intel.com/content/www/us/en/security-center/advisory/intel-sa-00699.html

Firmware has been available in fw_update for some time so systems which
track -current should already have the new -77 images.

Tested:
ax200: jmc, hrvoje, stsp
ax201: Mikhail, Sven Wolf, stsp
ax210: lraab, stsp
ax211: Mikhail, dv

date 2023-03-06T17:14:44Z
author miod
files src/sys/dev/wscons/wsemul_subr.c log diff annotate
src/sys/dev/wscons/wsemul_sun.c log diff annotate
src/sys/dev/wscons/wsemul_vt100.c log diff annotate
src/sys/dev/wscons/wsemul_vt100var.h log diff annotate
src/sys/dev/wscons/wsemulvar.h log diff annotate
message Replace old'n'wrong UTF-8 logic with a better one borrowed from Citrus;
issue reported by Crystal Kolipe on tech@

date 2023-03-06T17:20:05Z
author miod
files src/sys/arch/amd64/amd64/conf.c log diff annotate
message In iskmemdev(), do not check for the minor of /dev/io. It has been
deprecated more than 25 years ago and removed more than 20.
From Crystal Kolipe, thanks!

date 2023-03-06T17:20:06Z
author miod
files src/sys/arch/arm64/arm64/conf.c log diff annotate
src/sys/arch/i386/i386/conf.c log diff annotate
src/sys/arch/riscv64/riscv64/conf.c log diff annotate
message In iskmemdev(), do not check for the minor of /dev/io. It has been
deprecated more than 25 years ago and removed more than 20.
From Crystal Kolipe, thanks!

date 2023-03-06T20:34:35Z
author miod
files src/sys/dev/wscons/wsemul_sun.c log diff annotate
src/sys/dev/wscons/wsemul_vt100.c log diff annotate
message Correctly account the number of bytes processed when outputting UTF-8 encoded
characters.