created | 2022-11-16T14:59:44Z |
---|---|
begin | 2022-11-11T10:51:46Z |
end | 2022-11-11T10:55:48Z |
path | src/sys |
commits | 1 |
date | 2022-11-11T10:55:48Z | |||
---|---|---|---|---|
author | dlg | |||
files | src/sys/net/pfvar.h | log | diff | annotate |
src/sys/net/pfvar_priv.h | log | diff | annotate | |
message |
move struct pf_state from pfvar.h to pfvar_priv.h. we (sashan) are going to add a mutex to the pf_state struct, but a mutex is a kernel data structure that changes shape depending on things like whether MULTIPROCESSOR is enabled, and should therefore not be visible to userland. when we added a mutex to pf_state, compiling pfctl failed because it doesn't know what a mutex is and it can't know which version of it the current kernel is running with. moving struct pf_state to pfvar_priv.h makes it clear it is a private kernel only data structure, and avoids this leak into userland. tested by me and make build ok sashan@ |