OpenBSD cvs log

created 2022-03-26T18:01:37Z
begin 2022-03-21T00:00:00Z
end 2022-03-22T00:00:00Z
path src/sys
commits 16

date 2022-03-21T00:20:40Z
author krw
files src/sys/scsi/scsiconf.c log diff annotate
message No point in calling scsi_link_shutdown() if link->pool is NULL.

Ditto config_detach() if link->device_softc is NULL.

Currently just some extra paranoia, but will allow simplification
of exit logic in scsi_probe_link() and other future uses of
scsi_detach_link() on partially configured links.

No intentional functional change.

date 2022-03-21T03:51:09Z
author dlg
files src/sys/netinet/in_pcb.c log diff annotate
message treat 255.255.255.255 like an mcast address in in_pcbselsrc.

this allows the IP_MULTICAST_IF sockopt to specify which address
you want to send a limited broadcast (255.255.255.255) packet out
of.

requested by and ok claudio@

date 2022-03-21T04:00:56Z
author dlg
files src/sys/netinet/raw_ip.c log diff annotate
message call in_pcbselsrc from rip_output so route sourceaddr can take effect.

previously things that used sendto or similar with raw sockets would
ignore any configured sourceaddr. this made it inconsistent with
other traffic, which in turn makes things confusing to debug if
you're using ping or traceroute (which use raw sockets) to figure
out what's happening to other packets.

the ipv6 equiv already does this too.

ok sthen@ claudio@

date 2022-03-21T05:45:52Z
author visa
files src/sys/sys/atomic.h log diff annotate
message Remove data dependency barrier from atomic_load_* functions

This makes the atomic_load_* functions relaxed in terms of memory
ordering. Now it should be acceptable to use these functions in
assertions.

The need of the data dependency barrier is conditioned to usage.
The barrier is unnecessary for the control decisions that cond_wait()
and refcnt_finalize() make. READ_ONCE() and SMR_PTR_GET() use the
barrier so that loaded pointers would work as excepted in lock-free
contexts (some Alpha CPUs have a data cache design that can cause
unusual load-load reordering if not synchronized properly).

OK bluhm@

date 2022-03-21T06:48:00Z
author miod
files src/sys/arch/arm64/include/Attic/float.h log diff annotate
src/sys/arch/arm64/include/Attic/machdep.h log diff annotate
message Remove unused files which serve no purpose in OpenBSD; with and ok jsg@

(works better with `cvs rm' prior to commit...)

date 2022-03-21T09:12:34Z
author bluhm
files src/sys/kern/kern_sysctl.c log diff annotate
src/sys/netinet/in_pcb.c log diff annotate
src/sys/netinet/in_pcb.h log diff annotate
src/sys/netinet/raw_ip.c log diff annotate
src/sys/netinet/udp_usrreq.c log diff annotate
src/sys/netinet6/in6_pcb.c log diff annotate
src/sys/netinet6/raw_ip6.c log diff annotate
message Header netinet/in_pcb.h includes sys/mutex.h now. Recommit mutex
for PCB tables. It does not break userland build anymore.

pf_socket_lookup() calls in_pcbhashlookup() in the PCB layer. To
run pf in parallel, make parts of the stack MP safe. Protect the
list and hashes in the PCB tables with a mutex.
Note that the protocol notify functions may call pf via tcp_output().
As the pf lock is a sleeping rw_lock, we must not hold a mutex. To
solve this for now, collect these PCBs in inp_notify list and protect
it with exclusive netlock.
OK sashan@

date 2022-03-21T12:18:52Z
author thfr
files src/sys/dev/usb/uhid_rdesc.h log diff annotate
src/sys/dev/usb/uhidev.c log diff annotate
src/sys/dev/usb/uhidev.h log diff annotate
message Add support for XBox One gamecontroller, including report descriptor.
Based on previous XBox 360 controller code and NetBSD's implementation.

Tested by me and solene@.
Input by solene@ and stsp@.
ok stsp@ phessler@
ok solene@ for an earlier version.

date 2022-03-21T12:57:46Z
author krw
files src/sys/scsi/scsiconf.c log diff annotate
message Whitespace tweaks.

date 2022-03-21T13:38:34Z
author kettenis
files src/sys/dev/acpi/acpiac.c log diff annotate
message Update hw.power whenever we refresh the AC state. This makes sure the state
doesn't get out of sync with what apm(8) reports if power is plugged or
unplugged when a machine is suspended. Which in turn makes sure the machine
properly goes into a low CPU P-state when requested.

ok deraadt@, florian@

date 2022-03-21T19:22:39Z
author miod
files src/sys/arch/hppa/gsc/harmony.c log diff annotate
src/sys/arch/luna88k/cbus/nec86.c log diff annotate
src/sys/arch/luna88k/cbus/nec86var.h log diff annotate
src/sys/arch/macppc/dev/aoa.c log diff annotate
src/sys/arch/macppc/dev/awacs.c log diff annotate
src/sys/arch/macppc/dev/daca.c log diff annotate
src/sys/arch/macppc/dev/onyx.c log diff annotate
src/sys/arch/macppc/dev/snapper.c log diff annotate
src/sys/arch/macppc/dev/tumbler.c log diff annotate
src/sys/arch/sparc64/dev/ce4231.c log diff annotate
src/sys/dev/audio.c log diff annotate
message Constify struct {audio,midi,radio,video}_hw_if. No functional change.

ok mpi@ ratchov@ "More const is good" deraadt@

date 2022-03-21T19:22:40Z
author miod
files src/sys/dev/audio_if.h log diff annotate
src/sys/dev/midi.c log diff annotate
src/sys/dev/midi_if.h log diff annotate
src/sys/dev/midivar.h log diff annotate
src/sys/dev/radio.c log diff annotate
src/sys/dev/radio_if.h log diff annotate
src/sys/dev/radiovar.h log diff annotate
src/sys/dev/video.c log diff annotate
src/sys/dev/video_if.h log diff annotate
src/sys/dev/fdt/es8316ac.c log diff annotate
src/sys/dev/fdt/graphaudio.c log diff annotate
src/sys/dev/fdt/rkiis.c log diff annotate
src/sys/dev/fdt/simpleamp.c log diff annotate
src/sys/dev/fdt/simpleaudio.c log diff annotate
src/sys/dev/fdt/tascodec.c log diff annotate
src/sys/dev/ic/arcofi.c log diff annotate
src/sys/dev/ic/mpuvar.h log diff annotate
src/sys/dev/isa/ess.c log diff annotate
src/sys/dev/isa/gus.c log diff annotate
src/sys/dev/isa/gusvar.h log diff annotate
src/sys/dev/isa/mpu401.c log diff annotate
src/sys/dev/isa/pas.c log diff annotate
src/sys/dev/isa/sb.c log diff annotate
src/sys/dev/ofw/ofw_misc.h log diff annotate
src/sys/dev/pci/auacer.c log diff annotate
src/sys/dev/pci/auglx.c log diff annotate
src/sys/dev/pci/auich.c log diff annotate
src/sys/dev/pci/auixp.c log diff annotate
src/sys/dev/pci/autri.c log diff annotate
message Constify struct {audio,midi,radio,video}_hw_if. No functional change.

ok mpi@ ratchov@ "More const is good" deraadt@

date 2022-03-21T19:22:41Z
author miod
files src/sys/dev/pci/auvia.c log diff annotate
src/sys/dev/pci/azalia.c log diff annotate
src/sys/dev/pci/cmpci.c log diff annotate
src/sys/dev/pci/cs4280.c log diff annotate
src/sys/dev/pci/cs4281.c log diff annotate
src/sys/dev/pci/eap.c log diff annotate
src/sys/dev/pci/emuxki.c log diff annotate
src/sys/dev/pci/envy.c log diff annotate
src/sys/dev/pci/esa.c log diff annotate
src/sys/dev/pci/eso.c log diff annotate
src/sys/dev/pci/fms.c log diff annotate
src/sys/dev/pci/fmsradio.c log diff annotate
src/sys/dev/pci/maestro.c log diff annotate
src/sys/dev/pci/neo.c log diff annotate
src/sys/dev/pci/sv.c log diff annotate
src/sys/dev/pci/yds.c log diff annotate
src/sys/dev/pci/bktr/bktr_os.c log diff annotate
src/sys/dev/sbus/cs4231.c log diff annotate
src/sys/dev/tc/bba.c log diff annotate
message Constify struct {audio,midi,radio,video}_hw_if. No functional change.

ok mpi@ ratchov@ "More const is good" deraadt@

date 2022-03-21T19:22:42Z
author miod
files src/sys/dev/usb/uaudio.c log diff annotate
src/sys/dev/usb/udsbr.c log diff annotate
src/sys/dev/usb/umidi.c log diff annotate
src/sys/dev/usb/utvfu.c log diff annotate
src/sys/dev/usb/uvideo.c log diff annotate
message Constify struct {audio,midi,radio,video}_hw_if. No functional change.

ok mpi@ ratchov@ "More const is good" deraadt@

date 2022-03-21T19:39:56Z
author bluhm
files src/sys/netinet/udp_usrreq.c log diff annotate
message Fix whitespace. Wrap long lines. Adjust outdated comment.

date 2022-03-21T19:46:56Z
author kettenis
files src/sys/dev/pci/if_bwfm_pci.c log diff annotate
message Reduce dmesg spam by nor printing the "Apple" firmware name.

ok patrick@

date 2022-03-21T23:37:09Z
author bluhm
files src/sys/netinet/in_pcb.h log diff annotate
src/sys/netinet/udp_usrreq.c log diff annotate
message For multicast and broadcast packets udp_input() traverses the loop
of all UDP PCBs. From there it calls udp_sbappend() while holding
the UDP table mutex. This ends in sorwakeup() where we finally
grab the kernel lock while holding a mutex. Witness detects this
misuse.
Use the same solution as for PCB notify. Collect the affected PCBs
in a temporary list. The list is protected by exclusive net lock.
Reported-by: [email protected]
OK sashan@