OpenBSD cvs log

created 2022-02-13T02:21:02Z
begin 2022-02-11T00:00:00Z
end 2022-02-12T00:00:00Z
path src/sys
commits 8

date 2022-02-11T00:43:27Z
author deraadt
files src/sys/arch/arm64/dev/apm.c log diff annotate
message sleep_cpu/resume_cpu are part of an earlier MI split attempt
noticed by kettenis

date 2022-02-11T01:55:12Z
author deraadt
files src/sys/arch/amd64/amd64/acpi_machdep.c log diff annotate
src/sys/arch/arm64/dev/apm.c log diff annotate
src/sys/arch/i386/i386/acpi_machdep.c log diff annotate
src/sys/arch/macppc/dev/apm.c log diff annotate
src/sys/kern/subr_suspend.c log diff annotate
src/sys/sys/device.h log diff annotate
message the sleep_clocks() hook is not needed because the architectures which
need to do this can do it a few moments later in a different hook

date 2022-02-11T07:25:50Z
author visa
files src/sys/kern/kern_event.c log diff annotate
src/sys/sys/event.h log diff annotate
message Inline klist_empty() for more economic machine code.

OK mpi@

date 2022-02-11T07:27:07Z
author visa
files src/sys/sys/event.h log diff annotate
message Check klist emptiness instead of NULL pointer in KNOTE()

All callers of KNOTE() supply a non-NULL klist argument. Replace the
NULL pointer check with klist emptiness check as a small optimization.

OK mpi@

date 2022-02-11T07:28:29Z
author visa
files src/sys/net/bpf.c log diff annotate
message Replace manual !klist_empty()+knote() with KNOTE().

OK mpi@

date 2022-02-11T09:25:04Z
author kn
files src/sys/uvm/uvm_fault.c log diff annotate
src/sys/uvm/uvm_map.c log diff annotate
src/sys/uvm/uvm_map.h log diff annotate
message Backout previous "Assert vm map locks" (commitid: sRNBfzX2dJrxFDmb)

WITNESS builds broke as reported by anton and bluhm:

root on sd0a (5ec49b3ad23eb2d4.a) swap on sd0b dump on sd0b
kernel: protection fault trap, code=0
Stopped at witness_checkorder+0x4ec: movl 0x10(%r12),%ecx

https://syzkaller.appspot.com/bug?id=be02b290a93c648986c35370a271aad4135a5044
https://syzkaller.appspot.com/text?tag=CrashLog&x=136e9aa4700000

date 2022-02-11T12:06:48Z
author kn
files src/sys/uvm/uvm_map.c log diff annotate
message Backout previous "Unwire with map lock held" (commitid: eQBvWUwShD91dN9Z)

WITNESS builds broke^W^Wkernels panic on boot as reported by anton and bluhm.
Booting bsd.mp in single-user mode inside VMM shows:

root on sd0a (5f9e458ed30b39ab.a) swap on sd0b dump on sd0b
Enter pathname of shell or RETURN for sh:
witness: lock order reversal:
1st 0xfffffd801f8ce468 vmmaplk (&map->lock)
2nd 0xfffffd801b8162c0 inode (&ip->i_lock)
lock order "&ip->i_lock"(rrwlock) -> "&map->lock"(rwlock) first seen at:
#0 rw_enter_read+0x38
#1 uvmfault_lookup+0x8a
#2 uvm_fault_check+0x32
#3 uvm_fault+0xfb
#4 kpageflttrap+0x12c
#5 kerntrap+0x91
#6 alltraps_kern_meltdown+0x7b
#7 copyout+0x53
#8 ffs_read+0x1f6
#9 VOP_READ+0x41
#10 vn_rdwr+0xa1
#11 vmcmd_map_readvn+0xa0
#12 exec_process_vmcmds+0x88
#13 sys_execve+0x732
#14 start_init+0x26f
#15 proc_trampoline+0x1c
lock order data w1 -> w2 missing
# exit
kernel: protection fault trap, code=0
Stopped at witness_checkorder+0x312: movl 0x10(%r14),%ecx

gkoehler reported faults on poisened addresses on macppc dual G5.

date 2022-02-11T15:11:35Z
author millert
files src/sys/sys/statvfs.h log diff annotate
message Fix typo in comment for f_favail.
From Alf Schlichting