OpenBSD cvs log

created 2022-03-17T09:15:17Z
begin 2021-11-24T00:00:00Z
end 2021-12-01T00:00:00Z
path src/sys
commits 45

date 2021-11-24T09:47:49Z
author claudio
files src/sys/dev/dt/dt_prov_static.c log diff annotate
src/sys/kern/kern_smr.c log diff annotate
message Add a few dt(4) TRACEPOINTS to SMR. Should help to better understand what
goes on in SMR.
OK mpi@

date 2021-11-24T10:28:55Z
author claudio
files src/sys/kern/kern_sig.c log diff annotate
src/sys/sys/signalvar.h log diff annotate
message Minor code cleanup. Move a comment to the right place, move a function
to get a better order of functions. Also reduce the size of sigprop
to NSIG from NSIG+1. NSIG is defined as 33 and so includes the extra
element for this array.
OK mpi@

date 2021-11-24T10:40:15Z
author claudio
files src/sys/kern/kern_sig.c log diff annotate
message Refactor postsig_done(). Pass the catchmask and signal reset flag to the
function. This will make unlocking cursig() & postsig() a bit easier.
OK mpi@

date 2021-11-24T12:40:40Z
author visa
files src/sys/kern/kern_kthread.c log diff annotate
message Remove unneeded <sys/stdarg.h>.

OK guenther@

date 2021-11-24T13:16:00Z
author visa
files src/sys/kern/kern_smr.c log diff annotate
message Simplify arithmetics on the main path.

date 2021-11-24T13:17:37Z
author visa
files src/sys/kern/kern_smr.c log diff annotate
message Fix type of count.

date 2021-11-24T18:48:33Z
author bluhm
files src/sys/netinet/ip_output.c log diff annotate
src/sys/netinet6/ip6_output.c log diff annotate
message When sending ICMP packets for IPsec path MTU discovery, the first
ICMP packet could be wrong. The mtu was taken from the loopback
interface as the tdb mtu was copied to the route too late. Without
crypto task, ipsp_process_packet() returns the EMSGSIZE error
earlier. Immediately update tdb and route mtu.
IPv4 part from markus@; OK tobhe@

date 2021-11-24T21:47:14Z
author mglocker
files src/sys/dev/usb/utvfu.h log diff annotate
message Fix panic when running utvfu(4) on xhci(4).

tested and ok ian@

date 2021-11-24T21:57:56Z
author mglocker
files src/sys/dev/usb/utvfu.c log diff annotate
message Spacing

date 2021-11-24T22:03:05Z
author mglocker
files src/sys/dev/usb/utvfu.h log diff annotate
message Spacing and remove an unused macro.

date 2021-11-25T06:25:32Z
author anton
files src/sys/dev/usb/uhidev.c log diff annotate
message Assert that at least one report id is claimed during multiple report ids
attachment. Should prevent uhidev drivers from doing the wrong thing in their
corresponding match routine.

date 2021-11-25T13:46:02Z
author bluhm
files src/sys/net/if_bridge.c log diff annotate
src/sys/net/if_pfsync.c log diff annotate
src/sys/net/pfkeyv2.c log diff annotate
src/sys/net/pfkeyv2_convert.c log diff annotate
src/sys/netinet/ip_ipsp.c log diff annotate
src/sys/netinet/ip_ipsp.h log diff annotate
src/sys/netinet/ip_spd.c log diff annotate
src/sys/netinet/ipsec_input.c log diff annotate
src/sys/netinet/ipsec_output.c log diff annotate
src/sys/netinet/tcp_input.c log diff annotate
src/sys/netinet/tcp_output.c log diff annotate
src/sys/netinet/udp_usrreq.c log diff annotate
message Implement reference counting for IPsec tdbs. Not all cases are
covered yet, more ref counts to come. The timeouts are protected,
so the racy tdb_reaper() gets retired. The tdb_policy_head, onext
and inext lists are protected. All gettdb...() functions return a
tdb that is ref counted and has to be unrefed later. A flag ensures
that tdb_delete() is called only once.
Tested by Hrvoje Popovski; OK sthen@ mvs@ tobhe@

date 2021-11-25T14:51:26Z
author stsp
files src/sys/dev/pci/if_iwx.c log diff annotate
src/sys/dev/pci/if_iwxreg.h log diff annotate
src/sys/dev/pci/if_iwxvar.h log diff annotate
message Prepare iwx(4) for using new firmware (API version -67) in the future.

Bump command versions array size as required for -67 firmware.
Ignore new TLVs found in -67 images.
Add room for another ucode section needed for -67 on AX201 devices.

date 2021-11-25T20:31:24Z
author anton
files src/sys/dev/usb/uhidev.c log diff annotate
message revert recent change, breakage reported by dv@

date 2021-11-25T23:03:05Z
author deraadt
files src/sys/netinet/tcp_input.c log diff annotate
message move label to fix RAMDISK

date 2021-11-26T04:42:13Z
author visa
files src/sys/kern/kern_kthread.c log diff annotate
src/sys/sys/proc.h log diff annotate
src/sys/sys/signalvar.h log diff annotate
message Mark exit1() and sigexit() as non-returning

The late 1990s reasons for avoiding __dead with exit1() should not apply
with the current compilers.

This fixes compiler warnings about uninitialized variables in trap.c
on mips64.

Discussed with guenther@ and miod@

date 2021-11-26T11:44:01Z
author kettenis
files src/sys/dev/ofw/ofw_power.c log diff annotate
src/sys/dev/ofw/ofw_power.h log diff annotate
message Add interfaces to enable all power domains for a node.

ok patrick@, visa@

date 2021-11-26T14:45:13Z
author jsg
files src/sys/arch/arm/arm/cpu.c log diff annotate
src/sys/arch/arm64/arm64/cpu.c log diff annotate
src/sys/arch/mips64/mips64/cpu.c log diff annotate
src/sys/arch/riscv64/riscv64/cpu.c log diff annotate
message avoid clang -Wsometimes-uninitialized warning when MULTIPROCESSOR is not
defined
feedback from millert@, ok kettenis@, mips64 diff from and ok visa@

date 2021-11-26T14:59:42Z
author jsg
files src/sys/arch/powerpc/powerpc/trap.c log diff annotate
message avoid clang -Wsometimes-uninitialized warning when DDB is not defined
ok kettenis@ visa@

date 2021-11-26T15:21:26Z
author patrick
files src/sys/arch/arm64/dev/acpiiort.c log diff annotate
message The IORT table usually only contains single mappings. While on the LX2K there
is a non-single mapping for the networking subsystem, we don't yet have support
for it and apparently Linux has trouble with it as well. So for now we can
remove the code, because it uses an uninitialized variable and there's no easy
way to fix it without re-thinking the concept. The code got there in the first
place because it's a copy of the same pattern in our other IOMMU code.

ok jsg@

date 2021-11-26T16:16:35Z
author tobhe
files src/sys/net/pfkeyv2.c log diff annotate
src/sys/netinet/ip_ipsp.c log diff annotate
src/sys/netinet/ip_ipsp.h log diff annotate
message Replace TDBF_DELETED flag with check if tdb was already unlinked.
Protect tdb_unlink() and puttdb() for SADB_UPDATE with tdb_sadb_mutex.

Tested by Hrvoje Popovski
ok bluhm@ mvs@

date 2021-11-26T19:24:41Z
author bluhm
files src/sys/netinet/ip_ipsp.c log diff annotate
message Put a mutex assert locked into puttdb_locked().
OK tobhe@

date 2021-11-27T00:49:21Z
author jsg
files src/sys/arch/amd64/conf/Makefile.amd64 log diff annotate
src/sys/arch/arm64/conf/Makefile.arm64 log diff annotate
src/sys/arch/armv7/conf/Makefile.armv7 log diff annotate
src/sys/arch/i386/conf/Makefile.i386 log diff annotate
src/sys/arch/loongson/conf/Makefile.loongson log diff annotate
src/sys/arch/macppc/conf/Makefile.macppc log diff annotate
message stop building kernels with -Wno-uninitialized on clang archs
this hides real problems that could be found at build time

ok kettenis@ visa@, ok sashan@ on amd64/i386

date 2021-11-27T00:49:22Z
author jsg
files src/sys/arch/octeon/conf/Makefile.octeon log diff annotate
src/sys/arch/powerpc64/conf/Makefile.powerpc64 log diff annotate
src/sys/arch/riscv64/conf/Makefile.riscv64 log diff annotate
message stop building kernels with -Wno-uninitialized on clang archs
this hides real problems that could be found at build time

ok kettenis@ visa@, ok sashan@ on amd64/i386

date 2021-11-27T04:26:18Z
author jsg
files src/sys/dev/pci/drm/amd/display/dc/dcn20/dcn20_resource.c log diff annotate
src/sys/dev/pci/drm/amd/display/dc/dml/display_mode_enums.h log diff annotate
message drm/amd/display: Update swizzle mode enums

From Alvin Lee
3d68d6ee83144044f610d67304cc194c2af7d0c5 in linux 5.10.y/5.10.82
58065a1e524de30df9a2d8214661d5d7eed0a2d9 in mainline linux

date 2021-11-27T04:29:00Z
author jsg
files src/sys/dev/pci/drm/i915/display/intel_dp.c log diff annotate
message drm/i915/dp: Ensure sink rate values are always valid

From Imre Deak
47901b77bf7dc801a084a0b377aee5974d9bc4ce in linux 5.10.y/5.10.82
6c34bd4532a3f39952952ddc102737595729afc4 in mainline linux

date 2021-11-27T04:32:32Z
author jsg
files src/sys/dev/pci/drm/amd/amdgpu/amdgpu_connectors.c log diff annotate
message drm/amdgpu: fix set scaling mode Full/Full aspect/Center not works on vga and dvi connectors

From hongao
04c586a601dc0acb8e739205db350ab660dffc4f in linux 5.10.y/5.10.82
bf552083916a7f8800477b5986940d1c9a31b953 in mainline linux

date 2021-11-27T06:14:10Z
author deraadt
files src/sys/arch/powerpc64/dev/kexec.c log diff annotate
message free() with nullptr is OK, but not if the size is unitialized, and the
fail label is reachable before the sizes are known.

date 2021-11-27T11:22:26Z
author stsp
files src/sys/dev/pci/if_iwm.c log diff annotate
src/sys/dev/pci/if_iwmvar.h log diff annotate
message Let iwm(4) use per-Tx-queue interface timers to ensure that the interface
watchdog will trigger a device timeout if a particular Tx queue gets stuck
while other Tx queues keep working.

The Linux driver is using a similar workaround for "stuck queues".
I have only observed this problem on iwx(4) hardware but it won't hurt
to add this workaround to iwm(4) as well.

date 2021-11-27T16:25:40Z
author deraadt
files src/sys/dev/pci/if_ixl.c log diff annotate
message previous commit causes gcc to perform an unaligned access to the tcphdr
(at least on sparc64) since it accesses the bitfield using an "int sized"
instructions, rather than the minimally sized byte instruction. This is
permitted by the language laywers who probably prefer we change the tcphdr
in every packet. It is not clear how to convince gcc to avoid this behaviour,
and a week of futzing hasn't found fast path solutions yet. In the meantime
the tree may not be broken.

date 2021-11-28T09:25:02Z
author mglocker
files src/sys/dev/usb/dwc2/dwc2.c log diff annotate
src/sys/dev/usb/dwc2/dwc2_hcd.c log diff annotate
src/sys/dev/usb/dwc2/dwc2_hcdddma.c log diff annotate
message Align with the recent memory allocation changes we did for the other
USB HC drivers; M_DEVBUF -> M_USBHC.

ok kettenis@

date 2021-11-28T13:57:37Z
author mglocker
files src/sys/dev/usb/utvfu.c log diff annotate
message utvfu(4) only has one frame size, either for PAL or NTSC. Therefore
return EINVAL after the first frame size has been returned in the
VIDIOC_ENUM_FRAMESIZES ioctl.

ok mpi@

date 2021-11-28T14:10:32Z
author mglocker
files src/sys/dev/usb/utvfu.c log diff annotate
message Spacing

date 2021-11-29T01:04:45Z
author djm
files src/sys/crypto/blf.c log diff annotate
src/sys/crypto/blf.h log diff annotate
src/sys/lib/libsa/blowfish.c log diff annotate
src/sys/lib/libsa/blowfish.h log diff annotate
message Niels agreed to remove the advertising clause; switching these
to 3-term BSD license.

date 2021-11-29T15:39:59Z
author bluhm
files src/sys/net/pfkeyv2.c log diff annotate
src/sys/netinet/ip_ipsp.c log diff annotate
message Using a void pointer for temporary allocated TDB in pfkeyv2 does
not make sense. Do not use the freeme pointer for TDB in pfkeyv2_send().
The pattern is tdb_alloc() and tdb_unref() in case of error. Replace
tdb_free() in reserve_spi() with tdb_unref() to keep this consistent.
Only tdb_unref() should call tdb_free().
OK mvs@

date 2021-11-29T15:54:04Z
author visa
files src/sys/kern/kern_event.c log diff annotate
src/sys/sys/event.h log diff annotate
message kqueue: Revise badfd knote handling

When closing a file descriptor and converting the poll/select knotes
into badfd knotes, keep the knotes attached to the by-fd table. This
should prevent kqueue_purge() from returning before the kqueue has
become quiescent. This in turn should fix a
KASSERT(TAILQ_EMPTY(&kq->kq_head)) panic in KQRELE() that bluhm@ has
reported.

The badfd conversion is only needed when a poll/select scan is ongoing.
The system can skip the conversion if the knote is not part of the
active event set.

The code of this commit skips the conversion when the fd is closed by
the same thread that has done the fd polling. This can be improved but
should already cover typical fd usage patterns.

As badfd knotes now hold slots in the by-fd table, kqueue_register()
clears them. poll/select use kqueue_register() to set up a new scan;
any found fd close notification is a leftover from the previous scan.

The new badfd handling should be free of accidental knote accumulation.
This obsoletes kqpoll_dequeue() and lowers kqpoll_init() overhead.

Re-enable lazy removal of poll/select knotes because the panic should
no longer happen.

OK mpi@

date 2021-11-29T15:55:36Z
author dv
files src/sys/arch/amd64/amd64/vmm.c log diff annotate
message vmm(4): bump remote vmclear spinout ticks

Older/slower hosts could easily hit the cap under load. Set it to
the same value we use in mplock_debug.

ok mlarkin@

date 2021-11-29T16:30:30Z
author mvs
files src/sys/kern/syscalls.master log diff annotate
message Unlock accept(2) and accept4(2) syscalls. Unlock them both because they
follow the same code path.

ok bluhm@

date 2021-11-29T16:31:43Z
author mvs
files src/sys/kern/init_sysent.c log diff annotate
src/sys/kern/syscalls.c log diff annotate
src/sys/sys/syscall.h log diff annotate
src/sys/sys/syscallargs.h log diff annotate
message regen

date 2021-11-29T19:19:00Z
author bluhm
files src/sys/netinet/ip_ipsp.c log diff annotate
message The network stack currently uses IPL_SOFTNET. Consistently initialize
the TDB sadb mutex with that. The old IPL_NET was chosen by accident.
OK mpi@

date 2021-11-30T02:13:55Z
author deraadt
files src/sys/arch/riscv64/conf/GENERIC log diff annotate
message enable uhid/fido
from Ashton Fagg

date 2021-11-30T02:13:57Z
author deraadt
files src/sys/arch/riscv64/riscv64/conf.c log diff annotate
message enable uhid/fido
from Ashton Fagg

date 2021-11-30T02:58:33Z
author visa
files src/sys/kern/sys_generic.c log diff annotate
message Prevent select(2) from blocking if registering found pending events.

OK mpi@

date 2021-11-30T13:17:43Z
author bluhm
files src/sys/netinet/ip_ipsp.h log diff annotate
src/sys/netinet/ip_spd.c log diff annotate
message Remove unused parameter from ipsp_spd_inp().
OK mvs@ yasuoka@

date 2021-11-30T17:05:59Z
author deraadt
files src/sys/arch/powerpc64/conf/GENERIC log diff annotate
message add ixl(4)