| created | 2021-11-02T15:54:12Z |
|---|---|
| begin | 2021-10-24T21:24:22Z |
| end | 2021-10-24T21:37:49Z |
| path | src/sys |
| commits | 1 |
| date | 2021-10-24T21:37:49Z | |||
|---|---|---|---|---|
| author | deraadt | |||
| files | src/sys/dev/microcode/cyclades/cyzfirm2h.c | log | diff | annotate |
| message |
For open/openat, if the flags parameter does not contain O_CREAT, the 3rd (variadic) mode_t parameter is irrelevant. Many developers in the past have passed mode_t (0, 044, 0644, or such), which might lead future people to copy this broken idiom, and perhaps even believe this parameter has some meaning or implication or application. Delete them all. This comes out of a conversation where tb@ noticed that a strange (but intentional) pledge behaviour is to always knock-out high-bits from mode_t on a number of system calls as a safety factor, and his bewilderment that this appeared to be happening against valid modes (at least visually), but no sorry, they are all irrelevant junk. They could all be 0xdeafbeef. ok millert |
|||