| created | 2021-10-16T15:30:24Z |
|---|---|
| begin | 2021-10-13T00:00:00Z |
| end | 2021-10-14T00:00:00Z |
| path | src/sys |
| commits | 4 |
| date | 2021-10-13T13:08:58Z | |||
|---|---|---|---|---|
| author | bluhm | |||
| files | src/sys/arch/amd64/amd64/aesni.c | log | diff | annotate |
| src/sys/arch/amd64/amd64/via.c | log | diff | annotate | |
| src/sys/arch/arm64/arm64/cryptox.c | log | diff | annotate | |
| src/sys/arch/i386/i386/via.c | log | diff | annotate | |
| src/sys/arch/i386/pci/glxsb.c | log | diff | annotate | |
| src/sys/arch/octeon/dev/octcrypto.c | log | diff | annotate | |
| src/sys/crypto/crypto.c | log | diff | annotate | |
| src/sys/crypto/cryptodev.h | log | diff | annotate | |
| src/sys/crypto/cryptosoft.c | log | diff | annotate | |
| src/sys/dev/pci/hifn7751.c | log | diff | annotate | |
| src/sys/dev/pci/safe.c | log | diff | annotate | |
| src/sys/dev/pci/ubsec.c | log | diff | annotate | |
| message |
The kernel crypto framework sometimes returned an error, sometimes the callback was called, and sometimes both. So the caller of that API could not release resources correctly. A bunch of errors can or should not happen, replace them with an assert. Remove redundant checks. crypto_invoke() should not return the error, but pass it via callback. Some old hardware drivers keep part of their inconsistency as I cannot test them. OK mpi@ |
|||
| date | 2021-10-13T14:36:31Z | |||
|---|---|---|---|---|
| author | bluhm | |||
| files | src/sys/netinet/ip_ah.c | log | diff | annotate |
| src/sys/netinet/ip_esp.c | log | diff | annotate | |
| src/sys/netinet/ip_ipcomp.c | log | diff | annotate | |
| src/sys/netinet/ip_ipip.c | log | diff | annotate | |
| src/sys/netinet/ip_ipip.h | log | diff | annotate | |
| src/sys/netinet/ip_ipsp.c | log | diff | annotate | |
| src/sys/netinet/ip_ipsp.h | log | diff | annotate | |
| src/sys/netinet/ipsec_output.c | log | diff | annotate | |
| src/sys/netinet/tcp_subr.c | log | diff | annotate | |
| message |
The function ipip_output() was registered as .xf_output() xform function. But was is never called via this pointer. It would have immediatley crashed as mp is always NULL when called via .xf_output(). Do not set .xf_output to ipip_output. This allows to pass only the parameters which are actually needed and the control flow is clearer. OK mpi@ |
|||
| date | 2021-10-13T22:43:44Z | |||
|---|---|---|---|---|
| author | bluhm | |||
| files | src/sys/crypto/crypto.c | log | diff | annotate |
| src/sys/crypto/cryptodev.h | log | diff | annotate | |
| src/sys/dev/softraid_crypto.c | log | diff | annotate | |
| src/sys/dev/softraid_raid1c.c | log | diff | annotate | |
| src/sys/netinet/ip_ah.c | log | diff | annotate | |
| src/sys/netinet/ip_esp.c | log | diff | annotate | |
| src/sys/netinet/ip_ipcomp.c | log | diff | annotate | |
| src/sys/netinet/ipsec_input.c | log | diff | annotate | |
| src/sys/netinet/ipsec_output.c | log | diff | annotate | |
| message |
The function crypto_dispatch() never returns an error. Make it void and remove error handling in the callers. OK patrick@ mvs@ |
|||
| date | 2021-10-13T22:49:11Z | |||
|---|---|---|---|---|
| author | bluhm | |||
| files | src/sys/netinet/ipsec_input.c | log | diff | annotate |
| message |
Remove redundant NULL checks in IPsec which are never reached. ok mvs@ |
|||