OpenBSD cvs log

created 2021-07-25T04:14:29Z
begin 2021-07-20T00:00:00Z
end 2021-07-21T00:00:00Z
path src/sys
commits 9

date 2021-07-20T00:41:54Z
author mlarkin
files src/sys/dev/acpi/acpi.c log diff annotate
message Fix trailing whitespace in a few places.

No code change.

date 2021-07-20T07:51:08Z
author visa
files src/sys/arch/mips64/conf/files.mips64 log diff annotate
src/sys/lib/libkern/arch/mips64/Attic/sync.S log diff annotate
message Remove unneeded __sync_* library functions from the kernel.

These library functions were added as stopgaps because GCC 4.2.1
lacks the corresponding __sync_* builtins on mips64. However,
the builtins are now provided by Clang.

date 2021-07-20T07:53:39Z
author visa
files src/sys/arch/mips64/mips64/ipifuncs.c log diff annotate
message Remove bogus use of CPU_MAXID and get cpu_info only once.

date 2021-07-20T14:44:09Z
author stsp
files src/sys/dev/pci/if_iwx.c log diff annotate
message Make iwx_init() call iwx_stop() if we fail to move into SCAN state.

Generally, iwx_init() must either succeed or reset everything. In the case
I observed, the missing call to iwx_stop() left us with a non-zero refcount
for the newstate task which failed to perform the INIT -> SCAN transition.
The next ioctl request from userspace would then trigger a KASSERT in
iwx_init() which checks for old tasks that haven't run to completion.

This problem won't happen under normal conditions. It will happen if
the firmware crashes in response to a bad scan command, for instance.
I ran into this while working on support for newer iwx(4) firmware.

date 2021-07-20T14:44:37Z
author stsp
files src/sys/dev/pci/if_iwm.c log diff annotate
message Make iwm_init() call iwm_stop() if we fail to move into SCAN state.

Generally, iwm_init() must either succeed or reset everything. In the case
I observed, the missing call to iwm_stop() left us with a non-zero refcount
for the newstate task which failed to perform the INIT -> SCAN transition.
The next ioctl request from userspace would then trigger a KASSERT in
iwm_init() which checks for old tasks that haven't run to completion.

This problem won't happen under normal conditions. It will happen if
the firmware crashes in response to a bad scan command, for instance.
I ran into this while working on support for newer iwx(4) firmware.

date 2021-07-20T16:00:47Z
author stsp
files src/sys/dev/pci/if_iwm.c log diff annotate
message Do not attempt to load 7265D iwm(4) firmware on all 7265 devices.

There are several variants of 7265 devices, all of which share a PCI ID.
7265D devices can be told apart by looking at the hardware revision number.
Non-D 7265 devices won't load 7265D firmware. Load the 7265-17 image instead.

Problem reported and fix tested on a non-D 7265 by Tilo Stritzky.
Tested on a 7265D by myself.

date 2021-07-20T16:32:28Z
author bluhm
files src/sys/net/if.c log diff annotate
src/sys/net/pfkeyv2.c log diff annotate
message The current workaround to disable parallel IPsec did not work.
Variable nettaskqs must not change at runtime. Interface input
queues choose the thread during init with ifiq_softnet = net_tq().
So it cannot be modified after pfkeyv2_send() sets the first SA in
kernel. Also changing the calculation in net_tq() may call task_del()
with a different taskq than task_add().
Instead of restricting the index to the first softnet task, use an
exclusive lock. For now just move the comment. We can later decide
if a write net lock or kernel lock is better.
OK mvs@

date 2021-07-20T16:44:55Z
author mvs
files src/sys/net/if_pppx.c log diff annotate
src/sys/net/pipex.c log diff annotate
src/sys/net/pipex_local.h log diff annotate
message Turn pipex(4) session statistics to per-CPU counters. This makes pipex(4)
more compliant to bluhm@'s work on traffic forwarding parallelization.

ok yasuoka@ bluhm@

date 2021-07-20T18:33:59Z
author jcs
files src/sys/dev/pci/ksmn.c log diff annotate
message add AMD 17h/6xh Root Complex

ok brynet