OpenBSD cvs log

created 2021-01-30T23:11:27Z
begin 2021-01-27T00:00:00Z
end 2021-01-28T00:00:00Z
path src/sys
commits 9

date 2021-01-27T02:58:03Z
author visa
files src/sys/kern/kern_event.c log diff annotate
message kqueue: Fix termination assert

When a kqueue file is closed, the kqueue can still have threads
scanning it. Consequently, kqueue_terminate() can see scan markers
in the event queue. These markers are removed when the scanning threads
leave the kqueue. Take this into account when checking the queue's
state, to avoid a panic when kqueue is closed from under a thread.

OK anton@

Reported-by: [email protected]

date 2021-01-27T03:02:06Z
author dlg
files src/sys/net/pf.c log diff annotate
message don't run copies of packets made by dup-to through pf_test.

dup-to is kind of like what you do with a span port, but is a bit
more fine grained. it copies packets in a connection out an interface
so that connection can be monitored. it doesnt make sense for pf
to see the copied packets and try to match or create new states for
them either. at best it needs config to stop pf seeing the copies
(eg, set skip on $dup_to_tgt_if). at worst it breaks the connections
you're monitoring because the states in pf get confused.

found while discussing larger route-to changes on tech@.

ok bluhm@ sashan@

date 2021-01-27T04:46:21Z
author dlg
files src/sys/net/pf.c log diff annotate
message have pf_route{,6} clear the pf_pdesc mbuf ref early for route-to/reply-to.

pf_route and pf_route6 are called to take over delivery of the
packet with route-to and reply-to instead of letting it get processed
normally. for the dup-to handling, it copies the mbuf but leaves
the original mbuf in place. pf_route takes over the packet by
clearing the mbuf pointer in the pf_pdesc struct. this diff moves
the clearing of that pointer to the start of the function, rather
than checking for dup-to again on the way out of the function.

i think this is better because it means that it's more robust in
the face of future code changes. even if that's not true, it's still
shorter code in a forwarding path.

ok sashan@ jmatthew@

date 2021-01-27T07:46:11Z
author dlg
files src/sys/dev/pci/if_mcx.c log diff annotate
message do better accounting of how many msix interrupts we want to use.

ok jmatthew@

date 2021-01-27T08:32:46Z
author mglocker
files src/sys/dev/usb/ugen.c log diff annotate
message Be consistent in not using parameter names for function prototypes.

date 2021-01-27T10:47:58Z
author jsg
files src/sys/dev/pci/pcidevs log diff annotate
message add some more amdgpu devices

date 2021-01-27T10:48:44Z
author jsg
files src/sys/dev/pci/pcidevs.h log diff annotate
src/sys/dev/pci/pcidevs_data.h log diff annotate
message regen

date 2021-01-27T17:28:19Z
author mglocker
files src/sys/dev/usb/ugen.c log diff annotate
src/sys/dev/usb/uplcom.c log diff annotate
src/sys/dev/usb/usb.h log diff annotate
src/sys/dev/usb/usb_subr.c log diff annotate
src/sys/dev/usb/usbdi.c log diff annotate
src/sys/dev/usb/uvideo.c log diff annotate
message The usb configuration descriptor parameter providing the number of
available device interfaces is called 'bNumInterfaces'.

ok phessler@, thfr@ (who provided the man page diff)

date 2021-01-27T23:53:35Z
author dlg
files src/sys/net/pf.c log diff annotate
message if the route resolved in pf_route is invalid, generate an icmp error.

of course this is limited to the !dup-to case.

ok sashan@ bluhm@