| created | 2021-01-06T23:57:42Z |
|---|---|
| begin | 2020-12-01T00:00:00Z |
| end | 2020-12-01T11:28:03Z |
| path | src/sys |
| commits | 1 |
| date | 2020-12-01T11:28:03Z | |||
|---|---|---|---|---|
| author | sthen | |||
| files | src/sys/net/wg_noise.c | log | diff | annotate |
| message |
bzero the antireplay counter rwlock before rw_init'ing it, not after. This was triggering a WITNESS detection witness: lock_object uninitialized: 0xffff800000bcf0d8 Starting stack trace... witness_checkorder(ffff800000bcf0d8,9,0) at witness_checkorder+0xab rw_enter_write(ffff800000bcf0c8) at rw_enter_write+0x43 noise_remote_decrypt(ffff800000bcea48,c4992785,0,fffffd80073c89bc,10) at noise_remote_decrypt+0x135 wg_decap(ffff80000054a000,fffffd805f53ac00) at wg_decap+0xda wg_decap_worker(ffff80000054a000) at wg_decap_worker+0x7a taskq_thread(ffff80000012d900) at taskq_thread+0x9f alternating between two lock objects. From Matt Dunwoodie, thanks semarie@ for explanations about witness and looking at the code. |
|||