OpenBSD cvs log

created 2020-07-29T15:42:35Z
begin 2020-07-20T00:00:00Z
end 2020-07-21T00:00:00Z
path src/sys
commits 26

date 2020-07-20T00:15:59Z
author deraadt
files src/sys/conf/files log diff annotate
message __main() is no longer used by any of our toolchains
this fell out of a discussion with mortimer
ok kettenis

date 2020-07-20T00:16:01Z
author deraadt
files src/sys/lib/libkern/Attic/__main.c log diff annotate
message __main() is no longer used by any of our toolchains
this fell out of a discussion with mortimer
ok kettenis

date 2020-07-20T03:15:56Z
author jsg
files src/sys/dev/pci/drm/include/linux/timer.h log diff annotate
message use timeout_del_barrier(9) for del_timer_sync()

date 2020-07-20T07:45:44Z
author stsp
files src/sys/dev/ic/bwfm.c log diff annotate
src/sys/dev/ic/rt2560.c log diff annotate
src/sys/dev/ic/rt2661.c log diff annotate
src/sys/net80211/ieee80211_input.c log diff annotate
message The IEEE80211_F_HIDENWID flag is now part of ic_userflags, not ic_flags.
Fix code which was still looking for this flag at the old location.

The 'hidenwid' feature was slightly broken as a result: The SSID was leaked
in probe responses to wildcard probe requests. There are other trivial ways
of snooping a "hidden" SSID however so this is not a big deal.

Problem reported by Mogens Jensen.

date 2020-07-20T08:00:38Z
author stsp
files src/sys/dev/pci/if_iwn.c log diff annotate
message Make iwn_ampdu_tx_done() record an ACK for the frame for which the hardware
triggered the Tx completion interrupt, instead of the frame with the starting
sequence number (SSN) of the firmware's block ack window. The frame at SSN
is unrelated and may not even have been transmitted yet.

tested by bket@, jmc@, and myself
ok mpi@

date 2020-07-20T08:04:41Z
author stsp
files src/sys/dev/pci/if_iwn.c log diff annotate
message update a comment in iwn_ampdu_tx_done following previous SSN -> SEQ change

date 2020-07-20T08:09:30Z
author stsp
files src/sys/dev/pci/if_iwn.c log diff annotate
message Fix a logic bug in iwn(4) which meant that automatic rate control for
A-MPDU ran while a fixed Tx MCS was configured. The intention was of
course the inverse: Use automatic rate control if Tx MCS is not fixed.

There is a second bug which went unnoticed because of the above bug.
The value of 'seq' provided by firmware may be smaller than ba_winstart.
When this happened it triggered a KASSERT in ieee80211_output_ba_record_ack.
iwn_ampdu_rate_control() implicitly assumes that its 'seq' parameter equals
ba_winstart, so just pass that value directly.

tested by bket@, jmc@, and myself
ok mpi@

date 2020-07-20T08:19:59Z
author stsp
files src/sys/dev/pci/if_iwn.c log diff annotate
message Fix gain calibration for some iwn(4) devices (5000 and up).

IWN_LSB() returns an index starting with 1, however the arrays used
later on (noise and gain in iwn5000_set_gains()) start with 0. The
previous code accounted for this difference when setting the antenna
gain by accessing cmd.gain[i - 1]. However the noise array was accessed
with noise[i], the chainmask was checked against i, and more importantly
the overall for() loop iterated wrongly over the antennas by always
starting with i=2 (the third antenna). One consequence is that gain
calibration never happened in case of only two antennas.

Patch by Holger Mikolon.

date 2020-07-20T08:22:06Z
author stsp
files src/sys/dev/pci/if_iwn.c log diff annotate
message KNF for multi-line comment added to iwn5000_set_gains() in previous commit.

date 2020-07-20T12:40:45Z
author fcambus
files src/sys/dev/rasops/rasops.c log diff annotate
src/sys/dev/rasops/rasops32.c log diff annotate
src/sys/dev/rasops/rasops_bitops.h log diff annotate
message Fix various whitespace and formatting issues in rasops(9).

date 2020-07-20T13:34:31Z
author fcambus
files src/sys/dev/wsfont/spleen12x24.h log diff annotate
src/sys/dev/wsfont/spleen16x32.h log diff annotate
src/sys/dev/wsfont/spleen32x64.h log diff annotate
src/sys/dev/wsfont/spleen5x8.h log diff annotate
src/sys/dev/wsfont/spleen6x12.h log diff annotate
src/sys/dev/wsfont/spleen8x16.h log diff annotate
message Update Spleen kernel fonts to version 1.8.1, bringing the following
improvements:

- Center tilde vertically for all sizes, as modern fonts do

date 2020-07-20T13:55:32Z
author mvs
files src/sys/net/if.c log diff annotate
message Move insertions to `if_list' out of NET_LOCK() because KERNEL_LOCK()
protects this list. Also corresponding assertion added to be sure the
required lock was held.

This is the step to clean locking mess around `if_list'.

Also we are going to protect `if_list' by it's own lock and this will
allow us to avoid lock order issues in future.

ok dlg@

date 2020-07-20T14:34:16Z
author deraadt
files src/sys/kern/tty.c log diff annotate
src/sys/kern/tty_pty.c log diff annotate
message Sigh. Only the ptyc case should tsleep in ttyretype, since others can
arrive in the wrong context. Found by jcs.

date 2020-07-20T14:41:12Z
author krw
files src/sys/arch/luna88k/dev/mb89352.c log diff annotate
src/sys/arch/sparc64/dev/vdsk.c log diff annotate
src/sys/dev/softraid.c log diff annotate
src/sys/dev/vscsi.c log diff annotate
src/sys/dev/ata/atascsi.c log diff annotate
src/sys/dev/atapiscsi/atapiscsi.c log diff annotate
src/sys/dev/ic/aac.c log diff annotate
message Move remaining scsi bus initialization info from "prototype scsi link"
fields to struct scsibus_attach_args. Nuke the struct scsi_link *
(saa_sc_link) in scaibus_attach_args.

Explicitly initialize each field in scsibus_attach_args variables.

date 2020-07-20T14:41:13Z
author krw
files src/sys/dev/ic/adv.c log diff annotate
src/sys/dev/ic/adw.c log diff annotate
src/sys/dev/ic/aic6250.c log diff annotate
src/sys/dev/ic/aic6360.c log diff annotate
src/sys/dev/ic/aic79xx_openbsd.c log diff annotate
src/sys/dev/ic/aic7xxx_openbsd.c log diff annotate
src/sys/dev/ic/ami.c log diff annotate
src/sys/dev/ic/cac.c log diff annotate
src/sys/dev/ic/ciss.c log diff annotate
src/sys/dev/ic/gdt_common.c log diff annotate
src/sys/dev/ic/mfi.c log diff annotate
src/sys/dev/ic/mpi.c log diff annotate
src/sys/dev/ic/ncr53c9x.c log diff annotate
src/sys/dev/ic/nvme.c log diff annotate
src/sys/dev/ic/oosiop.c log diff annotate
src/sys/dev/ic/osiop.c log diff annotate
src/sys/dev/ic/qla.c log diff annotate
src/sys/dev/ic/qlw.c log diff annotate
src/sys/dev/ic/siop.c log diff annotate
src/sys/dev/ic/twe.c log diff annotate
src/sys/dev/ic/uha.c log diff annotate
src/sys/dev/ic/wd33c93.c log diff annotate
src/sys/dev/isa/wds.c log diff annotate
src/sys/dev/pci/arc.c log diff annotate
src/sys/dev/pci/iha_pci.c log diff annotate
src/sys/dev/pci/ips.c log diff annotate
src/sys/dev/pci/mfii.c log diff annotate
src/sys/dev/pci/mpii.c log diff annotate
message Move remaining scsi bus initialization info from "prototype scsi link"
fields to struct scsibus_attach_args. Nuke the struct scsi_link *
(saa_sc_link) in scaibus_attach_args.

Explicitly initialize each field in scsibus_attach_args variables.

date 2020-07-20T14:41:14Z
author krw
files src/sys/dev/pci/qle.c log diff annotate
src/sys/dev/pci/trm_pci.c log diff annotate
src/sys/dev/pci/vmwpvs.c log diff annotate
src/sys/dev/pv/hvs.c log diff annotate
src/sys/dev/pv/vioblk.c log diff annotate
src/sys/dev/pv/vioscsi.c log diff annotate
src/sys/dev/pv/xbf.c log diff annotate
src/sys/dev/sdmmc/sdmmc_scsi.c log diff annotate
src/sys/dev/usb/umass_scsi.c log diff annotate
src/sys/scsi/mpath.c log diff annotate
src/sys/scsi/scsiconf.c log diff annotate
src/sys/scsi/scsiconf.h log diff annotate
message Move remaining scsi bus initialization info from "prototype scsi link"
fields to struct scsibus_attach_args. Nuke the struct scsi_link *
(saa_sc_link) in scaibus_attach_args.

Explicitly initialize each field in scsibus_attach_args variables.

date 2020-07-20T16:09:48Z
author krw
files src/sys/dev/ic/aic7xxx_openbsd.c log diff annotate
message Missed a chunk somewhere along the line. Use our_id vs our_id_b in
appropriate spots. Don't copy one empty/unused scsi_link (channel) to
another empty/unused scsi_link (channel_b)

date 2020-07-20T17:18:51Z
author deraadt
files src/sys/arch/powerpc64/powerpc64/trap.c log diff annotate
message Add uvm_map_inentry call, to detect stack pivots at trap time.
ok kettenis

date 2020-07-20T17:55:28Z
author deraadt
files src/sys/kern/subr_prf.c log diff annotate
message fix macro indent

date 2020-07-20T17:57:46Z
author deraadt
files src/sys/arch/powerpc64/conf/Makefile.powerpc64 log diff annotate
message improve accuracy of kexec_subr.o dependency

date 2020-07-20T18:42:30Z
author deraadt
files src/sys/kern/tty.c log diff annotate
message cleanup ttrstrt; no functional change; ok dlg

date 2020-07-20T20:33:10Z
author krw
files src/sys/arch/luna88k/dev/mb89352.c log diff annotate
src/sys/arch/sparc64/dev/vdsk.c log diff annotate
message saa.ssa.wwpn is not the same as saa.saa_wwpn.

Typo broke miod's luna88k build. Would have broken next sparc64 build.

date 2020-07-20T20:38:10Z
author krw
files src/sys/dev/ic/aac.c log diff annotate
message Neither is saa.ssa.pool the same as saa.saa_pool.

date 2020-07-20T21:43:02Z
author cheloha
files src/sys/kern/kern_tc.c log diff annotate
message timecounting: misc. cleanup in tc_setclock() and tc_setrealtimeclock()

- Use real variable names like "utc" and "uptime" instead of non-names
like "bt" and "bt2"
- Move the TIMESPEC_TO_BINTIME(9) conversions out of the critical
section
- Sprinkle in a little whitespace
- Sort automatic variables according to style(9)

date 2020-07-20T21:51:34Z
author cheloha
files src/sys/kern/kern_tc.c log diff annotate
message timecounting: add missing mutex assertion to tc_update_timekeep()

date 2020-07-20T22:40:53Z
author deraadt
files src/sys/kern/kern_tc.c log diff annotate
message ramdisks got broken by that last diff.