| created | 2020-04-04T17:40:47Z |
|---|---|
| begin | 2020-04-01T00:00:00Z |
| end | 2020-04-02T00:00:00Z |
| path | src/sys |
| commits | 2 |
| date | 2020-04-01T07:15:59Z | |||
|---|---|---|---|---|
| author | mpi | |||
| files | src/sys/net/if_pppx.c | log | diff | annotate |
| message |
Disallow session timeout on pppx(4). The timeout code currently assumes that the `session' descriptor it deals with is independently allocated. This isn't true for pppx(4) and result in memory corruption. So disable the feature until the code is fixed. Bug reported and fix provided by Vitaliy Makkoveev. |
|||
| date | 2020-04-01T08:43:33Z | |||
|---|---|---|---|---|
| author | patrick | |||
| files | src/sys/dev/usb/usbdi.c | log | diff | annotate |
| message |
USB control requests to the root hub differ from those to devices. For devices we have proper DMA transfers, so that the DMA syncs before and after transfers are necessary. For the root hub, we seem to fulfill those requests ourselves, e.g. by using memcpy. The POSTREAD DMA sync on a read will invalidate the caches for the buffer, and unless our root hub code explicitly flushed the data to memory, it's possible that our memcpy got removed from history. Until a better solution is implemented, like moving the DMA syncs from the USB subsystem into the controller driver, allocate all buffers that are not explicitly allocated using USB_DMA_COHERENT. The IO buffers continue to be allocated as non-coherent. Regression found by jsg@ ok kettenis@ |
|||