| created | 2019-02-04T14:23:29Z |
|---|---|
| begin | 2019-02-02T00:00:00Z |
| end | 2019-02-03T00:00:00Z |
| path | src/sys |
| commits | 2 |
| date | 2019-02-02T14:32:58Z | |||
|---|---|---|---|---|
| author | visa | |||
| files | src/sys/arch/amd64/amd64/db_trace.c | log | diff | annotate |
| message |
Improve stack trace saving on amd64: * Replace unnecessary use of db_get_value() with direct access of f_retaddr. The trace function assumes that the chain of frames is good in terms of alignment and content. * Replace the for loop with a while loop and drop the check "frame != NULL" from the loop condition. The check is redundant with the "!INKERNEL(frame)" condition. The code already assumes that the initial frame is valid. * Stop iteration if f_retaddr is a non-kernel address in order to not save a user address at the end of the trace. This additionally fixes a kernel crash that would happen if the user thread had a broken frame pointer. * Fix erroneous skipping of the second stack frame. OK mpi@ |
|||
| date | 2019-02-02T14:34:09Z | |||
|---|---|---|---|---|
| author | visa | |||
| files | src/sys/arch/i386/i386/db_trace.c | log | diff | annotate |
| message |
Improve stack trace saving on i386: * Replace unnecessary use of db_get_value() with direct access of f_retaddr. The trace function assumes that the chain of frames is good in terms of alignment and content. * Replace the for loop with a while loop and drop the check "frame != NULL" from the loop condition. The check is redundant with the "!INKERNEL(frame)" condition. The code already assumes that the initial frame is valid. * Stop iteration if f_retaddr is a non-kernel address in order to not save a user address at the end of the trace. This additionally fixes a kernel crash that would happen if the user thread had a broken frame pointer. OK mpi@ |
|||